Fix: resolve code quality issues and minor bugs #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses several easy to medium-level code quality issues identified during a repository audit.
Changes:
util/landgraph/landgraph.js:outoption definition:typelabel->typeLabel. This ensures the help text displays correctly.if (options.help || options)was always true. Changed toif (options.help || Object.keys(options).length === 0)to correctly show help only when requested or no options are provided.generate-entities.sh:descriptionfield in the JMESPath query. This fixes a syntax error in the JSON projection.cleanup.sh:findandxargscommand to use-print0and-0respectively. This handles filenames with spaces or special characters correctly.-dflag fromfind.{}placeholder fromxargs.Impact:
These changes improve the correctness, stability, and portability of the codebase. No existing functionality is altered or broken.
Verification:
landgraph.jshelp logic now works as expected.generate-entities.shquery syntax is valid.cleanup.shcommand is syntactically correct and portable.Checklist: